Message 76416 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	akitada
Recipients	akitada, amaury.forgeotdarc, brett.cannon, rpetrov
Date	2008-11-25.16:09:04
SpamBayes Score	6.207981e-05
Marked as misclassified	No
Message-id	<1227629346.93.0.508901311626.issue4370@psf.upfronthosting.co.za>
In-reply-to

Content
Roumen, Thanks for the feedback! This patch disables __attribute__ when PY_FORMAT_SIZE_T isn't defined, not always. About the name of the macro, I think you are right. Py_GCC_FORMAT_ATTRIBUTE would be much better name if it is not used for other uses. (I'm not sure) I'll look into the code more and if it seems being safe to rename it, I'll update the patch and resubmit it.

Roumen,
Thanks for the feedback!

This patch disables __attribute__ when PY_FORMAT_SIZE_T isn't defined,
not always.

About the name of the macro, I think you are right.
Py_GCC_FORMAT_ATTRIBUTE would be much better name if it is not used for
other uses. (I'm not sure)
I'll look into the code more and if it seems being safe to rename it,
I'll update the patch and resubmit it.

History
Date	User	Action	Args
2008-11-25 16:09:07	akitada	set	recipients: + akitada, brett.cannon, amaury.forgeotdarc, rpetrov
2008-11-25 16:09:06	akitada	set	messageid: <1227629346.93.0.508901311626.issue4370@psf.upfronthosting.co.za>
2008-11-25 16:09:05	akitada	link	issue4370 messages
2008-11-25 16:09:05	akitada	create