Author vstinner
Recipients Neil Muller, davidfraser, hodgestar, tebeka, vstinner, werneck
Date 2008-11-15.00:33:11
SpamBayes Score 1.89068e-11
Marked as misclassified No
Message-id <1226709192.97.0.629434977999.issue2736@psf.upfronthosting.co.za>
In-reply-to
Content
I like the method, but I have some comments about the new method:
 - datetime_totimestamp() is not well indented
 - "PyObject *time" should be defined at the before the first 
instruction
 - why not using "if (time == NULL) return NULL;" directly instead of 
using a block in case of time is not NULL?
 - there are reference leaks: timetuple, timestamp and 
PyFloat_FromDouble()

I wrote a similar patch before reading 
add-datetime-totimestamp-method.diff which does exactly the same... I 
attach my patch but both should be merged.
History
Date User Action Args
2008-11-15 00:33:13vstinnersetrecipients: + vstinner, tebeka, davidfraser, werneck, hodgestar, Neil Muller
2008-11-15 00:33:12vstinnersetmessageid: <1226709192.97.0.629434977999.issue2736@psf.upfronthosting.co.za>
2008-11-15 00:33:12vstinnerlinkissue2736 messages
2008-11-15 00:33:12vstinnercreate