Author richard
Recipients richard
Date 2008-10-23.01:17:12
SpamBayes Score 1.56217e-05
Marked as misclassified No
Message-id <1224724634.09.0.0444621109477.issue4184@psf.upfronthosting.co.za>
In-reply-to
Content
Executive summary of the patch:

The attached patch removes the use of __private attributes in the smtpd
module allowing it to be extensible without needing to use the
"_<classname>__<attributename>" hack.


Summary of the patch's changes:

1. removes the unused __conn and __addr attributes
2. renames __server to smtp_server
3. renames __lines to received_lines
4. renames __state to smtp_state
5. renames __greeting to seen_greeting, and alters the default to empty
string to match the anticipated data
6. renames __mailfrom to mailfrom
7. renames __date to received_data
8. renames __fqdn to fqdn
9. removes __peer and uses base class' addr attribute

The existing unit tests contained within test_smtplib pass. Additional
tests could be written if it's deemed necessary.

There is a chance this patch will break backward compatibility with
programs that use the private-variable-access hack. A more complex patch
could be written providing greater compatibility if it's deemed necessary.
History
Date User Action Args
2008-10-23 01:17:14richardsetrecipients: + richard
2008-10-23 01:17:14richardsetmessageid: <1224724634.09.0.0444621109477.issue4184@psf.upfronthosting.co.za>
2008-10-23 01:17:13richardlinkissue4184 messages
2008-10-23 01:17:12richardcreate