Message75085
[Roumen Petrov]
> Modification for test_build_ext.py from above mentioned issue break
> non-posix builds.
Without that change the test fails on Unix platforms when the build is
not done inside the source directory. I guess the problem must be the
change from (essentially):
def _get_source_filename():
return os.path.join(sysconfig.project_base, 'Modules', 'xxmodule.c')
to
def _get_source_filename():
srcdir = sysconfig.get_config_var('srcdir')
return os.path.join(srcdir, 'Modules', 'xxmodule.c')
On POSIX, project_base is just the directory containing the Python
executable. I think the right thing to do is to fix the srcdir var on
non-POSIX systems. I don't have a Windows machine to test on. Could
someone test the get_python_inc2.patch with the non_posix_srcdir.patch
applied on top of it? |
|
Date |
User |
Action |
Args |
2008-10-22 16:13:41 | nas | set | recipients:
+ nas, rpetrov |
2008-10-22 16:13:40 | nas | set | messageid: <1224692020.67.0.0946877780741.issue4151@psf.upfronthosting.co.za> |
2008-10-22 16:13:39 | nas | link | issue4151 messages |
2008-10-22 16:13:39 | nas | create | |
|