Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, vstinner
Date 2008-10-07.13:05:58
SpamBayes Score 0.0277501
Marked as misclassified No
Message-id <1223384761.41.0.362907022937.issue3975@psf.upfronthosting.co.za>
In-reply-to
Content
The patch goes in the good direction, here are some remarks:

- The two calls to open() are missing the O_BINARY flag, necessary on
Windows to avoid newline translation. This may be important for some codecs.

- the GIL should be released around calls to open(); searching the whole
sys.path can be long.

Besides this, the "char* filename" is relevant only on utf8-encoded
filesystems, and will not work on windows with non-ascii filenames. But
this is another issue.
History
Date User Action Args
2008-10-07 13:06:01amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, vstinner
2008-10-07 13:06:01amaury.forgeotdarcsetmessageid: <1223384761.41.0.362907022937.issue3975@psf.upfronthosting.co.za>
2008-10-07 13:05:58amaury.forgeotdarclinkissue3975 messages
2008-10-07 13:05:58amaury.forgeotdarccreate