Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, benjamin.peterson, brett.cannon
Date 2008-09-30.16:00:58
SpamBayes Score 6.42284e-05
Marked as misclassified No
Message-id <1222790460.96.0.104534015771.issue4003@psf.upfronthosting.co.za>
In-reply-to
Content
r66677 introduces a reference leak in test_cprofile, as shown by
http://mail.python.org/pipermail/python-checkins/2008-September/074355.html

IMO, the code at the end of the function should not have been modified
this way. It is enough to do:

	if (PyErr_Occurred()) {
		PyErr_WriteUnraisable(pObj->externalTimer);
		return 0;
	}

it's the same "PyErr_WriteUnraisable" statement as 18 lines above, which
is valid because pObj->externalTimer is still a living python object
even if pObj is being cleared.
History
Date User Action Args
2008-09-30 16:01:01amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, brett.cannon, benjamin.peterson
2008-09-30 16:01:00amaury.forgeotdarcsetmessageid: <1222790460.96.0.104534015771.issue4003@psf.upfronthosting.co.za>
2008-09-30 16:01:00amaury.forgeotdarclinkissue4003 messages
2008-09-30 16:00:58amaury.forgeotdarccreate