Author timehorse
Recipients akuchling, amaury.forgeotdarc, georg.brandl, jimjjewett, mark, mrabarnett, pitrou, rsc, timehorse
Date 2008-09-26.18:04:36
SpamBayes Score 2.88196e-11
Marked as misclassified No
Message-id <1222452278.58.0.69724742143.issue2636@psf.upfronthosting.co.za>
In-reply-to
Content
Phew!  Okay, all you patches have been applied as I said in a previous
message, and you should now be able to check out
lp:~pythonregexp2.7/python/issue2636+01+09-02+17+18+19+20+21+24+26 where
you can then apply your latest known patch (rc2+7) to add a fix for the
findall / finditer bug.

However, please review my changes to:

a) lp:~pythonregexp2.7/python/issue2636-01+09-02+17
b) lp:~pythonregexp2.7/python/issue2636-01+09-02+17+26
c) lp:~pythonregexp2.7/python/issue2636-01+09-02+17+18+26
d) lp:~pythonregexp2.7/python/issue2636-01+09-02+17+18+19+20+21+26

To make sure my mergers are what your code snapshots should be.  I did
get one conflict with patch 5 IIRC where a reverse attribute was added
to the SRE_STATE struct, and get a weird grouping error when running the
tests for (a) and (b), which I think is a typo; a compile error
regarding the afore mentioned missing reverse attribute from patch 3 or
4 in (c) and the SRE_FLAG_REVERSE seems to have been lost in (d) for
some reason.

Also, if you feel like tackling any other issues, whether they have
numbers or not, and implementing them in your current development line,
please let me know so I can get all the documentation and development
branches set up.  Thanks and good luck!
History
Date User Action Args
2008-09-26 18:04:38timehorsesetrecipients: + timehorse, akuchling, georg.brandl, jimjjewett, amaury.forgeotdarc, pitrou, rsc, mark, mrabarnett
2008-09-26 18:04:38timehorsesetmessageid: <1222452278.58.0.69724742143.issue2636@psf.upfronthosting.co.za>
2008-09-26 18:04:38timehorselinkissue2636 messages
2008-09-26 18:04:36timehorsecreate