This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients amaury.forgeotdarc, benjamin.peterson, pitrou, rupole
Date 2008-09-25.23:07:20
SpamBayes Score 2.8166207e-08
Marked as misclassified No
Message-id <1222384038.6478.18.camel@fsol>
In-reply-to <1afaf6160809251330v2fc0529ei2ae1c954a2156fbe@mail.gmail.com>
Content
> I disagree. The test I added is really about compile, and its failure
> was really just a side effect of the buffer bug.

Well, I won't fight over it, but it's really meant to check an aspect of
memoryview behaviour - otherwise why would it be part of your patch ? -,
and as such it should be in test_memoryview (and if it's meant to check
compile() then it should be in some hypothetical test_compile :-)).

In general I find it annoying that many tests are dumped into "generic"
test files like test_builtin, rather than in the test file appropriate
for the functionality being tested.

That said, I haven't looked at the rest of the patch yet, sorry! (back
from holidays)
History
Date User Action Args
2008-09-25 23:07:21pitrousetrecipients: + pitrou, amaury.forgeotdarc, rupole, benjamin.peterson
2008-09-25 23:07:20pitroulinkissue3946 messages
2008-09-25 23:07:20pitroucreate