Message73822
> I disagree. The test I added is really about compile, and its failure
> was really just a side effect of the buffer bug.
Well, I won't fight over it, but it's really meant to check an aspect of
memoryview behaviour - otherwise why would it be part of your patch ? -,
and as such it should be in test_memoryview (and if it's meant to check
compile() then it should be in some hypothetical test_compile :-)).
In general I find it annoying that many tests are dumped into "generic"
test files like test_builtin, rather than in the test file appropriate
for the functionality being tested.
That said, I haven't looked at the rest of the patch yet, sorry! (back
from holidays) |
|
Date |
User |
Action |
Args |
2008-09-25 23:07:21 | pitrou | set | recipients:
+ pitrou, amaury.forgeotdarc, rupole, benjamin.peterson |
2008-09-25 23:07:20 | pitrou | link | issue3946 messages |
2008-09-25 23:07:20 | pitrou | create | |
|