Message73739
Skip Montanaro schrieb:
> Looks reasonable, though I'm no ctypes maven. Trivial little nit:
> In the comment just before the start of CField_FromDesc it says,
> in part:
>
> * Expects the size, index and offset for the current field in *psize and
> * *poffset, stores the total size so far in *psize, the offset for the next
>
> Note that it identifies three values (size, index, offset) as stored
> in two locations (*psize and *poffset). Seems like some sort of
> mismatch to me.
Unfortunately this is not the only comment that is out of date in the
ctypes sources. I wanted to touch as little code as possible in this patch.
Thanks. |
|
Date |
User |
Action |
Args |
2008-09-24 18:01:33 | theller | set | recipients:
+ theller, effbot, skip.montanaro, mgiuca, tim.maxwell |
2008-09-24 18:01:32 | theller | link | issue3547 messages |
2008-09-24 18:01:32 | theller | create | |
|