Message73738
Fredrik Lundh schrieb:
> Looks fine to me, except for the comment in the test suite. Should
>
> + # MS compilers do NOT combine c_short and c_int into
> + # one field, gcc doesn't.
>
> perhaps be
>
> + # MS compilers do NOT combine c_short and c_int into
> + # one field, gcc do.
Sure. But isn't this correct (or better) english, instead?
^^^^
> Is using explicit tests for MSVC vs. GCC a good idea, btw? What about
> other compilers? Can the test be changed to accept either value?
Well, MSVC and GCC are the only compilers that I use (and that are tested
on the buildbots, afaik). If a cygwin compiled Python, for example, fails
this test then of course the test must be changed.
Thanks. |
|
Date |
User |
Action |
Args |
2008-09-24 18:00:28 | theller | set | recipients:
+ theller, effbot, skip.montanaro, mgiuca, tim.maxwell |
2008-09-24 18:00:27 | theller | link | issue3547 messages |
2008-09-24 18:00:26 | theller | create | |
|