This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ncoghlan
Recipients amaury.forgeotdarc, jcea, ncoghlan, vstinner
Date 2008-09-22.21:02:03
SpamBayes Score 3.61414e-08
Marked as misclassified No
Message-id <1222117384.46.0.109168162544.issue3885@psf.upfronthosting.co.za>
In-reply-to
Content
Patch comments:
- the test suite section of the diff appears to have a number of changes
that are unrelated to this issue
- the purpose of the new do_not_close flag (i.e. avoiding the crash)
could use a comment at the point where it is referenced in the code
- aren't all those dummy=DB_close_internal(*) + Py_XDECREF calls also in
need of the PyErr_Clear() treatment?
- globally clearing *any* error unconditionally is typically a bad idea.
If there are certain 'expected' errors (such as the No Server error
Victor was triggering or other BSDDB errors) then those can be cleared
silently, but for other errors something should at least be written to
stderr to indicate that an error was ignored because it couldn't be
propagated back to the eval loop (and possibly even for the BSDDB errors).
History
Date User Action Args
2008-09-22 21:03:04ncoghlansetrecipients: + ncoghlan, jcea, amaury.forgeotdarc, vstinner
2008-09-22 21:03:04ncoghlansetmessageid: <1222117384.46.0.109168162544.issue3885@psf.upfronthosting.co.za>
2008-09-22 21:02:04ncoghlanlinkissue3885 messages
2008-09-22 21:02:03ncoghlancreate