This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jcea
Recipients amaury.forgeotdarc, jcea, vstinner
Date 2008-09-18.15:20:11
SpamBayes Score 7.75921e-11
Marked as misclassified No
Message-id <1221751214.14.0.187822924648.issue3885@psf.upfronthosting.co.za>
In-reply-to
Content
> Not only in these functions, but anywhere "dummy=" is followed by a
> Py_XDECREF(dummy);

Please, clarify this. I don't see your point.

> And code like this must also be changed (in DB_open):
>    if (makeDBError(err)) {
>        PyObject *dummy;
>
>        dummy=DB_close_internal(self,0);
>        Py_XDECREF(dummy);
>        return NULL;
>    }
> if DB_close_internal() raises an exception it will replace the
> original error set by makeDBError(). I'm not sure this is desirable.

I agree this could be an issue that need to be studied. Please, post a
new bug report for that (to be addressed in 2.6.1, I think, since this
issue doesn't crash the interpreter).

I post a patch for the bugs originally indicated in this bug report, an
another one (db.verify() regression).

*Please Review*. I will update python 2.6 svn when the review is done.
Thanks.
History
Date User Action Args
2008-09-18 15:20:14jceasetrecipients: + jcea, amaury.forgeotdarc, vstinner
2008-09-18 15:20:14jceasetmessageid: <1221751214.14.0.187822924648.issue3885@psf.upfronthosting.co.za>
2008-09-18 15:20:13jcealinkissue3885 messages
2008-09-18 15:20:13jceacreate