Message72109
Gregory,
IMHO your patch is better in all aspects.
Regarding my patch, the API wouldn't change at all, as the source reads:
while len(bytes) < int(n):
bytes += read(_urandomfd, n - len(bytes))
So "n - len(bytes)" restricts the API to what it was before. But it
would call int() for each loop iteration :/
@Pitrou: My patch still passed the float to read (to keep the current
behavior, warning included), but if doing that can be considered a bug,
let's get rid of the DeprecationWarning by passing an int. |
|
Date |
User |
Action |
Args |
2008-08-28 19:50:55 | ajaksu2 | set | recipients:
+ ajaksu2, gregory.p.smith, pitrou |
2008-08-28 19:50:55 | ajaksu2 | set | messageid: <1219953055.78.0.141040707387.issue3708@psf.upfronthosting.co.za> |
2008-08-28 19:50:55 | ajaksu2 | link | issue3708 messages |
2008-08-28 19:50:54 | ajaksu2 | create | |
|