This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ajaksu2
Recipients ajaksu2, gregory.p.smith, pitrou
Date 2008-08-28.19:50:54
SpamBayes Score 0.00018102469
Marked as misclassified No
Message-id <1219953055.78.0.141040707387.issue3708@psf.upfronthosting.co.za>
In-reply-to
Content
Gregory,
IMHO your patch is better in all aspects.

Regarding my patch, the API wouldn't change at all, as the source reads:
        while len(bytes) < int(n):
            bytes += read(_urandomfd, n - len(bytes))

So "n - len(bytes)" restricts the API to what it was before. But it
would call int() for each loop iteration :/

@Pitrou: My patch still passed the float to read (to keep the current
behavior, warning included), but if doing that can be considered a bug,
let's get rid of the DeprecationWarning by passing an int.
History
Date User Action Args
2008-08-28 19:50:55ajaksu2setrecipients: + ajaksu2, gregory.p.smith, pitrou
2008-08-28 19:50:55ajaksu2setmessageid: <1219953055.78.0.141040707387.issue3708@psf.upfronthosting.co.za>
2008-08-28 19:50:55ajaksu2linkissue3708 messages
2008-08-28 19:50:54ajaksu2create