Author amaury.forgeotdarc
Recipients ajaksu2, amaury.forgeotdarc, christian.heimes
Date 2008-08-24.21:16:27
SpamBayes Score 0.00101415
Marked as misclassified No
Message-id <1219612588.43.0.422016094533.issue3662@psf.upfronthosting.co.za>
In-reply-to
Content
The "goto error" is not necessary here. Nothing has been allocated at
this point, and "return -1" is enough.

Index: Modules/_fileio.c
===================================================================
--- Modules/_fileio.c   (revision 65957)
+++ Modules/_fileio.c   (working copy)
@@ -175,7 +175,7 @@
                                                 kwlist,
                                                
Py_FileSystemDefaultEncoding,
                                                 &name, &mode, &closefd))
-                       goto error;
+                       return -1;
            }
        }
History
Date User Action Args
2008-08-24 21:16:28amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, christian.heimes, ajaksu2
2008-08-24 21:16:28amaury.forgeotdarcsetmessageid: <1219612588.43.0.422016094533.issue3662@psf.upfronthosting.co.za>
2008-08-24 21:16:27amaury.forgeotdarclinkissue3662 messages
2008-08-24 21:16:27amaury.forgeotdarccreate