Message71799
Sorry for the initial noise - your analysis is correct, mine was flawed
:) Simple recursion to a depth of 1000 does work fine on a 64bit build.
cpickle.patch does make test_cpickle pass for me. FWIW,
find_recursionlimit.py now causes a segfault on 32 and 64bit Windows
(the comments imply a MemoryError is expected there), and the 32bit
version dies at a depth of 5900, while the 64bit version dies at 3800
(both doing an 'add') - so it does seem there is still a discrepancy -
but not one we need to care about now.
I'm +1 in general on this, but I'm not sure that I'm +1 on this patch
for 1.6 without more careful review than I am able to offer at the
moment; it seems fairly unlikely to be hit "in the wild", but I'll
obviously defer that to others. OTOH, having the test suite segfault
isn't a good look, so we probably need to do *something* for 1.6 |
|
Date |
User |
Action |
Args |
2008-08-23 01:26:55 | mhammond | set | recipients:
+ mhammond, amaury.forgeotdarc, pitrou |
2008-08-23 01:26:55 | mhammond | set | messageid: <1219454815.13.0.0618444732933.issue3640@psf.upfronthosting.co.za> |
2008-08-23 01:26:54 | mhammond | link | issue3640 messages |
2008-08-23 01:26:53 | mhammond | create | |
|