Author jimjjewett
Recipients gvanrossum, janssen, jimjjewett, loewis, mgiuca, orsenthil, pitrou, thomaspinckney3
Date 2008-08-06.22:25:35
SpamBayes Score 0.0512749
Marked as misclassified No
Message-id <1218061538.26.0.630668725783.issue3300@psf.upfronthosting.co.za>
In-reply-to
Content
> http://codereview.appspot.com/2827/diff/1/5#newcode1450
> Line 1450: "%3c%3c%0Anew%C3%A5/%C3%A5",
> I'm guessing this test broke otherwise?  

Yes; that is one of the breakages you found in Bill's patch.  (He didn't 
modify the test.)

> Given that this references an RFC,
> is it correct to just fix it this way?

Probably.  Looking at http://www.faqs.org/rfcs/rfc2965.html

(1)  That is not among the exact tests in the RFC.
(2)  The RFC does not specify charset for the cookie in general, but the 
Comment field MUST be in UTF-8, and the only other reference I could find to 
a specific charset was "possibly in a server-selected printable ASCII 
encoding."

Whether we have to use Latin-1 (or document charset) in practice for 
compatibility reasons, I don't know.
History
Date User Action Args
2008-08-06 22:25:38jimjjewettsetrecipients: + jimjjewett, gvanrossum, loewis, janssen, orsenthil, pitrou, thomaspinckney3, mgiuca
2008-08-06 22:25:38jimjjewettsetmessageid: <1218061538.26.0.630668725783.issue3300@psf.upfronthosting.co.za>
2008-08-06 22:25:37jimjjewettlinkissue3300 messages
2008-08-06 22:25:35jimjjewettcreate