Author pitrou
Recipients janssen, jimjjewett, loewis, mgiuca, orsenthil, pitrou, thomaspinckney3
Date 2008-08-06.18:39:41
SpamBayes Score 0.000166681
Marked as misclassified No
Message-id <1218047983.5.0.0177619326626.issue3300@psf.upfronthosting.co.za>
In-reply-to
Content
Bill, I haven't studied your patch in detail but a few comments:
- it would be nice to have more unit tests, especially for the various
bytes/unicode possibilities, and perhaps also roundtripping (Matt's
patch has a lot of tests)
- quote_as_bytes() should return a bytes object, not a bytearray
- using the "%02X" format looks clearer to me than going through the
_hextable lookup table...
- when the argument is of the wrong type, quote_as_bytes() should raise
a TypeError rather than a ValueError
- why is quote_as_string() hardwired to utf8 while unquote_as_string()
provides a charset parameter? wouldn't it be better for them to be
consistent with each other?
History
Date User Action Args
2008-08-06 18:39:43pitrousetrecipients: + pitrou, loewis, jimjjewett, janssen, orsenthil, thomaspinckney3, mgiuca
2008-08-06 18:39:43pitrousetmessageid: <1218047983.5.0.0177619326626.issue3300@psf.upfronthosting.co.za>
2008-08-06 18:39:42pitroulinkissue3300 messages
2008-08-06 18:39:42pitroucreate