This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gregory.p.smith
Recipients ghaering, gregory.p.smith, hongqn, thekorn
Date 2008-08-04.03:55:54
SpamBayes Score 0.0281486
Marked as misclassified No
Message-id <1217822160.77.0.803913164557.issue2277@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks.  I've looked over your code.  The logic looks good, however I'd
like to propose a better design and that this not be included in 2.6.

Instead of putting this functionality in the MozCookieJar class, it
should be its own new Firefox3CookieJar class as it is an entirely new
file format.

A much better implementation could be made that actually works with the
sqlite3 file as a database rather than taking ownership of it and
deleting all cookies and rewriting the entire file on save:

The FileCookieJar.delayload flag could now be honored.

The save() method should only do the necessary update/insert/delete
commands rather than rewriting everything.

Its a bit late to get this into Python 2.6/3.0 as the final beta is due
out next week.  But thats fine.  People who need to manipulate ff3
cookie files can use sqlite directly and when a nicer FileCookieJar for
them has been written we can consider including it in python 2.7/3.1. 
Until then it can be an external just like the the one for IE currently is.
History
Date User Action Args
2008-08-04 03:56:00gregory.p.smithsetrecipients: + gregory.p.smith, ghaering, thekorn, hongqn
2008-08-04 03:56:00gregory.p.smithsetmessageid: <1217822160.77.0.803913164557.issue2277@psf.upfronthosting.co.za>
2008-08-04 03:55:55gregory.p.smithlinkissue2277 messages
2008-08-04 03:55:54gregory.p.smithcreate