Author lemburg
Recipients amaury.forgeotdarc, barry, benjamin.peterson, donmez, gpolo, lemburg, loewis, pitrou, teoliphant
Date 2008-08-02.14:32:52
SpamBayes Score 0.000464032
Marked as misclassified No
Message-id <1217687574.3.0.274060770682.issue3139@psf.upfronthosting.co.za>
In-reply-to
Content
Two comments:

 * I like the new *-getarg parameters, but it would be better to test
   for '#' first since this is still by far the most used getarg
   parameter.

 * Antoine, I think your codecs.c patch has a glitch:

+    decoded = PyUnicode_DecodeMBCSStateful(pbuf.buf, pbuf.len, errors,
+					   final ? NULL : &consumed);
+	PyBuffer_Release(&pbuf);
+    if (decoded == NULL)
 	return NULL;
-    return codec_tuple(decoded, final ? size : consumed);
+    return codec_tuple(decoded, consumed);
 }
 
   You dropped the "final ? size : " for no apparent reason.
History
Date User Action Args
2008-08-02 14:32:54lemburgsetrecipients: + lemburg, loewis, barry, teoliphant, amaury.forgeotdarc, pitrou, donmez, benjamin.peterson, gpolo
2008-08-02 14:32:54lemburgsetmessageid: <1217687574.3.0.274060770682.issue3139@psf.upfronthosting.co.za>
2008-08-02 14:32:53lemburglinkissue3139 messages
2008-08-02 14:32:53lemburgcreate