This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients lemburg, pitrou
Date 2008-07-28.19:04:37
SpamBayes Score 7.07701e-05
Marked as misclassified No
Message-id <1217271878.68.0.784852839744.issue3460@psf.upfronthosting.co.za>
In-reply-to
Content
In py3k, PyUnicode_Join inherits some complexity from the 2.x days.
However, it seems some of the precautions taken there may not be needed
anymore. Witness the following comment:

    /* Grrrr.  A codec may be invoked to convert str objects to
     * Unicode, and so it's possible to call back into Python code
     * during PyUnicode_FromObject(), and so it's possible for a sick
     * codec to change the size of fseq (if seq is a list).  Therefore
     * we have to keep refetching the size -- can't assume seqlen
     * is invariant.
     */

Perhaps it would also allow to preallocate the target buffer all at once
(like bytes.join does) rather than resize it incrementally.
Marc-Andre, what do you think?
History
Date User Action Args
2008-07-28 19:04:38pitrousetrecipients: + pitrou, lemburg
2008-07-28 19:04:38pitrousetmessageid: <1217271878.68.0.784852839744.issue3460@psf.upfronthosting.co.za>
2008-07-28 19:04:38pitroulinkissue3460 messages
2008-07-28 19:04:37pitroucreate