This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gboutsioukis
Recipients cjw296, gboutsioukis
Date 2008-07-04.15:01:02
SpamBayes Score 0.004121996
Marked as misclassified No
Message-id <1215183664.65.0.798785112819.issue3250@psf.upfronthosting.co.za>
In-reply-to
Content
Hi Chris,
 
 I know copy-pasted sounds horrible--perhaps I should have said 'modeled
afterwards'(better marketing;). The thing is, the datetime & time
classes share a lot of common functionality; it is inevitable that some
code looks like it's repeated, because the same process is followed(take
a look at the datetime & date functions already there). 
 I can't see much room for refactoring the arithmetic functions across
classes(seems too messy). Besides, the existing timezone, normalization
and delta functions are used, so no significant logic is repeated.The
patch indeed requires some cleanup, but overall it's good code(and not a
lot of it). 
 I submitted it without tests/doc because I think there should be a
chance for this functionality to be discussed. Also, the datetime module
looks like for some reason these functions were left out(some discussion
I'm missing?).

So before investing any more time on this some feedback would be
appreciated.
History
Date User Action Args
2008-07-04 15:01:05gboutsioukissetspambayes_score: 0.004122 -> 0.004121996
recipients: + gboutsioukis, cjw296
2008-07-04 15:01:04gboutsioukissetspambayes_score: 0.004122 -> 0.004122
messageid: <1215183664.65.0.798785112819.issue3250@psf.upfronthosting.co.za>
2008-07-04 15:01:03gboutsioukislinkissue3250 messages
2008-07-04 15:01:02gboutsioukiscreate