Author aalbrecht
Recipients aalbrecht, barry, cjw296, splorgdar
Date 2008-06-22.12:06:43
SpamBayes Score 0.00409423
Marked as misclassified No
Message-id <1214136414.48.0.213530823136.issue1974@psf.upfronthosting.co.za>
In-reply-to
Content
For me this issue seems to be a duplicate of issue1645148.

In my opinion the test case that checks if headers created by strings or
Header instances are equal is incorrect. It shouldn't set the
continuation whitespace explicitly when creating a Headers instance. I
would expect that

  A) msg['aheader'] = 'a long string that breaks, but shortened here'

and

  B) msg['aheader'] = Header('a long string that breaks, but shortened
here')

result in the same output. But for A) a Header instance is initialized
in Generator._write_headers() with continuation_ws set to `\t` and for
B) the default ' ' is used (see http://bugs.python.org/msg31102).

I'm uploading a patch that modifies test_string_headerinst_eq() to what
I think it should look like with this message. Of course, this test will
fail at the moment, but maybe you agree that the Header instance in this
test should be initialized without explicitly setting continuation_ws.
History
Date User Action Args
2008-06-22 12:06:55aalbrechtsetspambayes_score: 0.00409423 -> 0.00409423
recipients: + aalbrecht, barry, cjw296, splorgdar
2008-06-22 12:06:54aalbrechtsetspambayes_score: 0.00409423 -> 0.00409423
messageid: <1214136414.48.0.213530823136.issue1974@psf.upfronthosting.co.za>
2008-06-22 12:06:53aalbrechtlinkissue1974 messages
2008-06-22 12:06:51aalbrechtcreate