This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Rhamphoryncus
Recipients Rhamphoryncus, jjt009, jnoller, roudkerk
Date 2008-06-13.01:48:06
SpamBayes Score 0.00242807
Marked as misclassified No
Message-id <1213321687.42.0.935924935799.issue3095@psf.upfronthosting.co.za>
In-reply-to
Content
This doesn't look right.  PyDict_SetItemString doesn't steal the
references passed to it, so your reference to flags will be leaked each
time.  Besides, I think it's a little cleaner to INCREF it before call
PyModule_AddObject, then DECREF it at any point you return.

Additionally, I've just noticed that the result of Py_BuildValue is
getting leaked.  It should be stored to a temporary, added to flags,
then the temporary should be released.
History
Date User Action Args
2008-06-13 01:48:07Rhamphoryncussetspambayes_score: 0.00242807 -> 0.00242807
recipients: + Rhamphoryncus, roudkerk, jnoller, jjt009
2008-06-13 01:48:07Rhamphoryncussetspambayes_score: 0.00242807 -> 0.00242807
messageid: <1213321687.42.0.935924935799.issue3095@psf.upfronthosting.co.za>
2008-06-13 01:48:06Rhamphoryncuslinkissue3095 messages
2008-06-13 01:48:06Rhamphoryncuscreate