This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Rhamphoryncus
Recipients Rhamphoryncus, Rhamphoryncus, akuchling, arigo, djmitche, dugan, jafo, jepler, loewis
Date 2008-05-10.19:27:20
SpamBayes Score 0.00090443227
Marked as misclassified No
Message-id <1210447641.62.0.846756791232.issue1174606@psf.upfronthosting.co.za>
In-reply-to
Content
new_buffersize returns a size_t.  You should use SIZE_MAX instead
(although I don't see it used elsewhere in CPython, so maybe there's
portability problems.)

The call to _PyString_Resize implicitly casts the size_t to Py_ssize_t.
 The check against PY_SSIZE_T_MAX does make this safe, but a comment
would make it more obvious.

The latest patch uses spaces for indentation, which don't match up with
the existing tabs.
History
Date User Action Args
2008-05-10 19:27:22Rhamphoryncussetspambayes_score: 0.000904432 -> 0.00090443227
recipients: + Rhamphoryncus, loewis, akuchling, arigo, jepler, jafo, djmitche, rhamphoryncus.historic, dugan
2008-05-10 19:27:21Rhamphoryncussetspambayes_score: 0.000904432 -> 0.000904432
messageid: <1210447641.62.0.846756791232.issue1174606@psf.upfronthosting.co.za>
2008-05-10 19:27:21Rhamphoryncuslinkissue1174606 messages
2008-05-10 19:27:20Rhamphoryncuscreate