Message 65664 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gregory.p.smith
Recipients	CurtHagenlocher, akuchling, draghuram, gregory.p.smith, pitrou, schmir
Date	2008-04-21.18:00:38
SpamBayes Score	0.025722383
Marked as misclassified	No
Message-id	<1208800858.69.0.524324653467.issue2632@psf.upfronthosting.co.za>
In-reply-to

Content
Twisted fixed their problem for issue 1092502 by making recv()ed data short lived by putting it into a StringIO for buffering. I've attached a patch that does that for the socket module -and- gets rid of any possibility of doing tiny size recvs in read() which is the cause of the poor performance that this issue was filed about. My patch also documents what _rbufsize is used for (readline) and makes sane use of it with read. When viewing the change, it is best to view it side by side next to the old version rather than trying to comprehend it as a diff. I believe this really fixes both issue 1092502 while at the same time prevents introduction of a speed problem (this issue).

Twisted fixed their problem for issue 1092502 by making recv()ed data
short lived by putting it into a StringIO for buffering.

I've attached a patch that does that for the socket module -and- gets
rid of any possibility of doing tiny size recvs in read() which is the
cause of the poor performance that this issue was filed about.

My patch also documents what _rbufsize is used for (readline) and makes
sane use of it with read.

When viewing the change, it is best to view it side by side next to the
old version rather than trying to comprehend it as a diff.

I believe this really fixes both issue 1092502 while at the same time
prevents introduction of a speed problem (this issue).

History
Date	User	Action	Args
2008-04-21 18:00:59	gregory.p.smith	set	spambayes_score: 0.0257224 -> 0.025722383 recipients: + gregory.p.smith, akuchling, pitrou, draghuram, schmir, CurtHagenlocher
2008-04-21 18:00:58	gregory.p.smith	set	spambayes_score: 0.0257224 -> 0.0257224 messageid: <1208800858.69.0.524324653467.issue2632@psf.upfronthosting.co.za>
2008-04-21 18:00:53	gregory.p.smith	link	issue2632 messages
2008-04-21 18:00:52	gregory.p.smith	create