Author schmir
Recipients a_lauer, akuchling, bacchusrx, bob.ippolito, christian.heimes, martey, schmir, vila
Date 2008-04-14.21:07:38
SpamBayes Score 0.109985
Marked as misclassified No
Message-id <1208207259.29.0.824659012419.issue1092502@psf.upfronthosting.co.za>
In-reply-to
Content
Well, I think the right thing to do is limit the maximal size to be read
inside the c function (just to make it impossible to pass around large
values). This is basically the same fix just at another place in the code.


http://twistedmatrix.com/trac/ticket/1079 describes the same problem
(but with 64 k read requests: it can even leak with small requests).
The fix there was to really copy those strings around into a StringIO
object.

Note that the code does not read byte by byte when passing in no size
argument. Instead it read recv_size bytes:

            if self._rbufsize <= 1:
                recv_size = self.default_bufsize
            else:
                recv_size = self._rbufsize

This seems clearly wrong to me.
History
Date User Action Args
2008-04-14 21:07:39schmirsetspambayes_score: 0.109985 -> 0.109985
recipients: + schmir, akuchling, bob.ippolito, bacchusrx, a_lauer, christian.heimes, vila, martey
2008-04-14 21:07:39schmirsetspambayes_score: 0.109985 -> 0.109985
messageid: <1208207259.29.0.824659012419.issue1092502@psf.upfronthosting.co.za>
2008-04-14 21:07:38schmirlinkissue1092502 messages
2008-04-14 21:07:38schmircreate