Author jnferguson
Recipients amaury.forgeotdarc, belopolsky, gregory.p.smith, jnferguson
Date 2008-04-09.20:01:32
SpamBayes Score 0.0031293
Marked as misclassified No
Message-id <1207771294.21.0.107543156601.issue2587@psf.upfronthosting.co.za>
In-reply-to
Content
> 1. If you change PyString_FromStringAndSize, you should change
> PyBytes_FromStringAndSize and PyUnicode_FromStringAndSize for
> consistency.

Okay, if we don't patch the API call itself, I will look at the users of
those two API calls as well, I haven't gone through much of the stuff in
Objects/ yet, I focused on the modules obviously and thus didn't know
about those calls.

> 4. You have clearly identified several bugs that are not covered by
> unittests.  If you fix them en-mass by making
> PyString_FromStringAndSize more forgiving, we will miss an opportunity
> to improve the test coverage. (If you take the SystemError approach,
> this does not apply.)

This is a valid and good point-- I don't mind either way
History
Date User Action Args
2008-04-09 20:01:34jnfergusonsetspambayes_score: 0.0031293 -> 0.0031293
recipients: + jnferguson, gregory.p.smith, amaury.forgeotdarc, belopolsky
2008-04-09 20:01:34jnfergusonsetspambayes_score: 0.0031293 -> 0.0031293
messageid: <1207771294.21.0.107543156601.issue2587@psf.upfronthosting.co.za>
2008-04-09 20:01:33jnfergusonlinkissue2587 messages
2008-04-09 20:01:32jnfergusoncreate