Author donlorenzo
Recipients donlorenzo, jafo, nascheme
Date 2008-04-04.18:06:19
SpamBayes Score 0.0428624
Marked as misclassified No
Message-id <1207332444.69.0.347556220159.issue2250@psf.upfronthosting.co.za>
In-reply-to
Content
I confirmed that the rlcompleter can raise a SyntaxError on bad input.
Upon further investigation I found that a ReferenceError could also be
raised. I didn't check on other Exceptions.

I attached a new version of the patch where I catch all Errors derived
from Exceptions (not SystemError and KeyboardInterrupt).

while this seems rather drastic I really feel that this step should in
no case raise an Exception. I can't possibly think of a situation where
someone would want that.

Concerning the docs:
"...it will try to evaluate anything without obvious side-effects..."
I would consider raising an exception as a major side-effect so this
patch rather brings the code into accordance with the docs than it
contradicts them.
History
Date User Action Args
2008-04-04 18:07:24donlorenzosetspambayes_score: 0.0428624 -> 0.0428624
recipients: + donlorenzo, nascheme, jafo
2008-04-04 18:07:24donlorenzosetspambayes_score: 0.0428624 -> 0.0428624
messageid: <1207332444.69.0.347556220159.issue2250@psf.upfronthosting.co.za>
2008-04-04 18:06:21donlorenzolinkissue2250 messages
2008-04-04 18:06:20donlorenzocreate