➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, calvin, georg.brandl
Date 2008-03-28.13:24:30
SpamBayes Score 0.06967924
Marked as misclassified No
Message-id <1206710672.99.0.0653615343431.issue2503@psf.upfronthosting.co.za>
In-reply-to
Content 
Yes, PEP8 says::

    Comparisons to singletons like None should always be done with
    'is' or 'is not', never the equality operators.

Reading the patch:
- a change modifies "x == False" into "not x", another moves some lines.
I checked that they are OK (x is already the result of a comparison).
- some occurrences of "x != None" are not replaced. Why? (ex. in
test_ast.py)
History
Date User Action Args
2008-03-28 13:24:33amaury.forgeotdarcsetspambayes_score: 0.0696792 -> 0.06967924
recipients: + amaury.forgeotdarc, georg.brandl, calvin
2008-03-28 13:24:33amaury.forgeotdarcsetspambayes_score: 0.0696792 -> 0.0696792
messageid: <1206710672.99.0.0653615343431.issue2503@psf.upfronthosting.co.za>
2008-03-28 13:24:32amaury.forgeotdarclinkissue2503 messages
2008-03-28 13:24:31amaury.forgeotdarccreate