Author rolland
Recipients loewis, rolland
Date 2008-03-27.23:55:22
SpamBayes Score 0.166482
Marked as misclassified No
Message-id <47EC33E5.4070905@ghs.com>
In-reply-to <1206649729.22.0.142738455289.issue2497@psf.upfronthosting.co.za>
Content
Some compilers define false and true as macros.
When doing this, the definition in asdl.h (included from asdl.c) which 
is originally :
typedef enum {false, true} bool;
therefore becomes :
typedef enum {0, 1} bool;
which is non-sensical.
Using stdbool.h when it is available will ensure bool is defined as a 
type following the correct definition, which may or may not be an enum 
depending on the compiler.
Even when using gcc, stdbool.h is here to define bool in C language, so 
why not use it ?

--Rolland

Martin v. Löwis wrote:
> Martin v. Löwis <martin@v.loewis.de> added the comment:
>
> Why does it improve portability to use stdbool.h when it exists?
>
> What is the potential issue with asdl.c that gets fixed with this patch?
>
> ----------
> nosy: +loewis
>
> __________________________________
> Tracker <report@bugs.python.org>
> <http://bugs.python.org/issue2497>
> __________________________________
>
History
Date User Action Args
2008-03-27 23:55:24rollandsetspambayes_score: 0.166482 -> 0.166482
recipients: + rolland, loewis
2008-03-27 23:55:23rollandlinkissue2497 messages
2008-03-27 23:55:23rollandcreate