This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author tim.golden
Recipients ggenellina, tim.golden
Date 2008-03-17.08:08:40
SpamBayes Score 0.49920842
Marked as misclassified No
Message-id <47DE2742.9040207@timgolden.me.uk>
In-reply-to <1205715572.75.0.0970173613617.issue2304@psf.upfronthosting.co.za>
Content
Gabriel Genellina wrote:
> Gabriel Genellina <gagsl-py2@yahoo.com.ar> added the comment:
> 
> You aren't testing the modified code, the Popen call should say 
> shell=True.
> 
> I think that a more PEP8-compliant style would be nice (removing the 
> spaces after open and read, and using consistent indentation)

D'oh. Thanks, Gabriel. I'll rework the test and tidy
up the patch.
History
Date User Action Args
2008-03-17 08:08:42tim.goldensetspambayes_score: 0.499208 -> 0.49920842
recipients: + tim.golden, ggenellina
2008-03-17 08:08:40tim.goldenlinkissue2304 messages
2008-03-17 08:08:40tim.goldencreate