Author roberte
Recipients
Date 2008-03-11.16:12:13
SpamBayes Score 0.0
Marked as misclassified No
Message-id
In-reply-to
Content
Damn I should have looked here earlier - so I implemented FTPS based on
ftplib myself yesterday (looked quite similar). I had a look at you
patch and got one question.
In FTP_TLS.__init__ you call FTP.__init__. The latter in turn calls
FTP.login if a username is supplied. Thus you end up trying to login
before issuing the AUTH TLS command. The result is, that username and
passwords are send unencrypted. Or do I miss a subtle trick here? I
solved that problem by wrapping FTP.connect in my subclass, essentially
calling an FTP.connect and then it would be in this case an auth_tls and
prot_p afterwards.
History
Date User Action Args
2008-03-16 21:02:06gvanrossumsetspambayes_score: 0.915065 -> 0.0
2008-03-11 16:12:14robertelinkissue2054 messages
2008-03-11 16:12:13robertecreate