Author georg.brandl
Recipients georg.brandl, gpolo, loewis
Date 2008-03-06.06:59:39
SpamBayes Score 0.0486211
Marked as misclassified No
Message-id <1204786782.1.0.452477089387.issue2240@psf.upfronthosting.co.za>
In-reply-to
Content
Patch review:
* ItimerError should be signal.ItimerError, not signal.error.
* It should probably inherit from EnvironmentError or IOError.
* itimer_retval will leak the new tuple if one of the PyFloat_FromDouble
fails.
* Do you have test and doc patches, too?
* What does the "which" argument mean, is it an arbitrary integer
identifying the timer?
History
Date User Action Args
2008-03-06 06:59:42georg.brandlsetspambayes_score: 0.0486211 -> 0.0486211
recipients: + georg.brandl, loewis, gpolo
2008-03-06 06:59:42georg.brandlsetspambayes_score: 0.0486211 -> 0.0486211
messageid: <1204786782.1.0.452477089387.issue2240@psf.upfronthosting.co.za>
2008-03-06 06:59:40georg.brandllinkissue2240 messages
2008-03-06 06:59:39georg.brandlcreate