Author belopolsky
Recipients belopolsky, pitrou, stargaming
Date 2008-02-29.21:33:15
SpamBayes Score 0.0623903
Marked as misclassified No
Message-id <1204320797.96.0.761556173229.issue1766304@psf.upfronthosting.co.za>
In-reply-to
Content
Here are my comments on the py3k patch:

1. Sign of a PyLong object o is the same as the sign of Py_SIZE(o).  I 
would think it is safe to use this fact within python core.  (User code 
that may need to work across multiple versions of python may need to be 
more conservative.)

2. If you choose to use zero in the code, there is no need to create it 
twice per call.

3. Py_INCREF(zero); is unnecessary and creates a reference leak.

4. range_contains should return -1 when error is detected, not 0.

2.
History
Date User Action Args
2008-02-29 21:33:18belopolskysetspambayes_score: 0.0623903 -> 0.0623903
recipients: + belopolsky, pitrou, stargaming
2008-02-29 21:33:17belopolskysetspambayes_score: 0.0623903 -> 0.0623903
messageid: <1204320797.96.0.761556173229.issue1766304@psf.upfronthosting.co.za>
2008-02-29 21:33:16belopolskylinkissue1766304 messages
2008-02-29 21:33:15belopolskycreate