This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author maltehelmert
Recipients belopolsky, christian.heimes, gvanrossum, maltehelmert, pitrou, rbp
Date 2008-02-24.19:22:45
SpamBayes Score 0.02294786
Marked as misclassified No
Message-id <1203880967.05.0.554428596959.issue1040026@psf.upfronthosting.co.za>
In-reply-to
Content
Alexander, your one-line patch *does* affect performance on my 64-bit
Linux machine in a worse way than any other proposed patch by calling
sysconf five times. HZ may be defined on your machine, but it isn't on
my (Xeon) machine.

I checked man pages on four different Linuxes (32 bit and 64 bit; SuSE,
Fedora, Ubuntu; recent or six years old). All of them state that using
the sysconf value is the right thing to do. This is also stated in the
man page excerpt in Guido's original bug report.

Neither your latest patch (posixmodule.diff) not my latest patch
(os_times4.PATCH) affects performance; they both only call sysconf once
and then used a cached value.

I'm perfectly fine with your posixmodule.diff, which also meets
Antoine's criteria. I suggest we apply that patch, along with the unit
test from os_times4.PATCH, and be done with it.
History
Date User Action Args
2008-02-24 19:22:47maltehelmertsetspambayes_score: 0.0229479 -> 0.02294786
recipients: + maltehelmert, gvanrossum, belopolsky, pitrou, christian.heimes, rbp
2008-02-24 19:22:47maltehelmertsetspambayes_score: 0.0229479 -> 0.0229479
messageid: <1203880967.05.0.554428596959.issue1040026@psf.upfronthosting.co.za>
2008-02-24 19:22:46maltehelmertlinkissue1040026 messages
2008-02-24 19:22:45maltehelmertcreate