Author rhettinger
Recipients arigo, belopolsky, christian.heimes, dalke, loewis, rhettinger, tds333
Date 2008-02-24.02:34:00
SpamBayes Score 0.0334045
Marked as misclassified No
Message-id <1203820441.75.0.391209171898.issue1367711@psf.upfronthosting.co.za>
In-reply-to
Content
I think some variant of these patches was rejected before and part of 
these reason had to do with subtle semantic changes when switching from 
an old-style class (inheriting from UserDict) to a new-style class 
(inheriting from dict).  There were also some concerns that it could 
break code currently relying on isinstance(x, UserDict).

IMO, this just isn't work it.  The os.environ use cases are not 
typically the performance critical part of a script.  This is a false 
optimization.  The primary motivation seems to be that the OP doesn't 
like UserDict.

Looking at the patch, I find the existing code to be more self-
evidently correct and maintainable than the proposed new code.  Though 
this is probably a matter of taste.
History
Date User Action Args
2008-02-24 02:34:01rhettingersetspambayes_score: 0.0334045 -> 0.0334045
recipients: + rhettinger, loewis, arigo, dalke, belopolsky, tds333, christian.heimes
2008-02-24 02:34:01rhettingersetspambayes_score: 0.0334045 -> 0.0334045
messageid: <1203820441.75.0.391209171898.issue1367711@psf.upfronthosting.co.za>
2008-02-24 02:34:01rhettingerlinkissue1367711 messages
2008-02-24 02:34:00rhettingercreate