Message 62697 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	belopolsky
Recipients	belopolsky, brett.cannon, christian.heimes, dgreiman
Date	2008-02-22.20:38:16
SpamBayes Score	0.33059728
Marked as misclassified	No
Message-id	<1203712697.7.0.699382769509.issue2135@psf.upfronthosting.co.za>
In-reply-to

Content
I've noticed that the proposed patch adds const qualifier to many C-API functions' arguments. While at the first glance these changes are reasonable, they add clutter to the already massive patch. I would recommend to separate const qualifier changes into a separate patch that can be reviewed separately from the substantive changes. I promise, I will make substantive comments soon. :-)

I've noticed that the proposed patch adds const qualifier to many C-API 
functions' arguments.  While at the first glance these changes are 
reasonable, they add clutter to the already massive patch.

I would recommend to separate const qualifier changes into a separate 
patch that can be reviewed separately from the substantive changes.

I promise, I will make substantive comments soon. :-)

History
Date	User	Action	Args
2008-02-22 20:38:18	belopolsky	set	spambayes_score: 0.330597 -> 0.33059728 recipients: + belopolsky, brett.cannon, christian.heimes, dgreiman
2008-02-22 20:38:17	belopolsky	set	spambayes_score: 0.330597 -> 0.330597 messageid: <1203712697.7.0.699382769509.issue2135@psf.upfronthosting.co.za>
2008-02-22 20:38:16	belopolsky	link	issue2135 messages
2008-02-22 20:38:16	belopolsky	create