Author eric.smith
Recipients amaury.forgeotdarc, christian.heimes, eric.smith, gvanrossum, mark
Date 2008-02-17.22:34:18
SpamBayes Score 0.000654094
Marked as misclassified No
Message-id <1203287660.48.0.581779172953.issue1600@psf.upfronthosting.co.za>
In-reply-to
Content
The PEP 3101 float formatting code (in Objects/stringlib/formatter.h)
uses PyOS_ascii_formatd for all specifier codes except 'n'.  So applying
the patch would fix the issue that was originally brought up in msg58485.

I think the approach of the patch (if not its content, I haven't
inspected it yet) is correct.  Fix the underlying code and benefit from
this everywhere.  I don't think we should change the tests to be more
tolerant, I think we should be consistent across platforms.

My only concern is breaking code in the wild.  This seems like a change
with wide-reaching implications.

I think 'n' should also be addressed.  It calls PyOS_snprintf directly.

I'll review the patch and comment back here.  Unfortunately, I don't
have a Windows box set up for testing.
History
Date User Action Args
2008-02-17 22:34:20eric.smithsetspambayes_score: 0.000654094 -> 0.000654094
recipients: + eric.smith, gvanrossum, amaury.forgeotdarc, christian.heimes, mark
2008-02-17 22:34:20eric.smithsetspambayes_score: 0.000654094 -> 0.000654094
messageid: <1203287660.48.0.581779172953.issue1600@psf.upfronthosting.co.za>
2008-02-17 22:34:19eric.smithlinkissue1600 messages
2008-02-17 22:34:18eric.smithcreate