This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mkc
Recipients giampaolo.rodola, mkc
Date 2008-02-13.15:59:40
SpamBayes Score 0.0039836955
Marked as misclassified No
Message-id <1202918382.95.0.952374301523.issue2073@psf.upfronthosting.co.za>
In-reply-to
Content
The value is used there, but this is not effective in causing larger
packets to be sent, which I noticed by watching with strace.  I think
the reason for this is that 'refill_buffer' will only make at most one
call to simple_producer.more, and that call will produce at most 512
bytes, because that's the default value of that argument, and its not
overridden in the call that creates the simple_producer inside of 'push'.

In addition, I see at least one other place in the code where the
constant '512' appears.  Probably all of these should be changed to use
the 'ac_*' values, or at least a larger constant.

Looking at the big picture, though, I don't understand why we're trying
to break this stuff up in the first place.  That seems like the job of
the OS, and it may well do it faster and better anyway.  I would think
that every call to socket 'send' should try to ram as much data through
as possible.  The return value will let us know what actually happened.

(In my application, send's of size >200K are regularly succeeding, as
seen with strace.  I got this behavior by overriding 'push' with a fixed
version.)
History
Date User Action Args
2008-02-13 15:59:43mkcsetspambayes_score: 0.0039837 -> 0.0039836955
recipients: + mkc, giampaolo.rodola
2008-02-13 15:59:42mkcsetspambayes_score: 0.0039837 -> 0.0039837
messageid: <1202918382.95.0.952374301523.issue2073@psf.upfronthosting.co.za>
2008-02-13 15:59:41mkclinkissue2073 messages
2008-02-13 15:59:40mkccreate