This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author draghuram
Recipients draghuram, facundobatista, gvanrossum, init, pitrou
Date 2008-01-29.20:53:20
SpamBayes Score 0.025797967
Marked as misclassified No
Message-id <1201640002.66.0.481455287869.issue1577@psf.upfronthosting.co.za>
In-reply-to
Content
We are back to square 1 :-). Your patch incorporates Facundo's
suggestion which is 'rename(src_file, dst_dir/`basename src_file`). It
is not clear to me from rereading the earlier comments whether Guido
rejected this approach or not. I would personally prefer this approach.
If this change is not going to be considered, we will be left with
making a doc change; something to the effect:

"If the destination is a file and is on same file system as that of
src, then simply use rename."

An additional doc change will be needed to correct the statement "If dst
is a directory, OSError will be raised". As you found out, this is not
entirely true on Linux and perhaps on other versions of unix. 

I don't think any other changes are needed. I did not go through the
test cases in the patch but I think we can certainly use some of them
even if no code change is done.
History
Date User Action Args
2008-01-29 20:53:23draghuramsetspambayes_score: 0.025798 -> 0.025797967
recipients: + draghuram, gvanrossum, facundobatista, pitrou, init
2008-01-29 20:53:22draghuramsetspambayes_score: 0.025798 -> 0.025798
messageid: <1201640002.66.0.481455287869.issue1577@psf.upfronthosting.co.za>
2008-01-29 20:53:21draghuramlinkissue1577 messages
2008-01-29 20:53:20draghuramcreate