Author alanmcintyre
Recipients alanmcintyre, ehuss, gvanrossum
Date 2008-01-09.07:00:06
SpamBayes Score 0.0120386
Marked as misclassified No
Message-id <1199862009.9.0.576661102944.issue1622@psf.upfronthosting.co.za>
In-reply-to
Content
Here's the first draft of a patch (zipfile-unsigned-fixes.diff) that
does a few things:

- Interpret fields as unsigned unless required (CRC, etc.)
- Corrects reading of ZIP files with large archive comments
- Replaces hard-coded structure sizes with module-level variables
(calculated using struct.calcsize)
- When writing a file in ZipFile.close(), if the ZipFile instance has a
comment value, this value is now written as the archive comment
- Renamed some of the module variables to better match the names used in
the ZIP file spec
- General cleanup & addition of comments to (hopefully) make the code a
little easier to follow

Test & doc changes are included, & this code currently passes regression
test suite with -uall on OS X.
History
Date User Action Args
2008-01-09 07:00:10alanmcintyresetspambayes_score: 0.0120386 -> 0.0120386
recipients: + alanmcintyre, gvanrossum, ehuss
2008-01-09 07:00:09alanmcintyresetspambayes_score: 0.0120386 -> 0.0120386
messageid: <1199862009.9.0.576661102944.issue1622@psf.upfronthosting.co.za>
2008-01-09 07:00:08alanmcintyrelinkissue1622 messages
2008-01-09 07:00:07alanmcintyrecreate