Author gvanrossum
Recipients Rhamphoryncus, christian.heimes, gvanrossum, mark.dickinson
Date 2008-01-03.00:11:00
SpamBayes Score 0.0367313
Marked as misclassified No
Message-id <1199319060.95.0.0776451148099.issue1640@psf.upfronthosting.co.za>
In-reply-to
Content
One nit: you added a blank line to the end of test_math.py.
This will cause the checkin to fail. :-)

One bigger issue: the sign() function doesn't seem to work properly for
nans.  E.g. on Linux I get:

>>> inf = 1e1000
>>> nan = inf/inf
>>> mnan = -nan
>>> math.sign(nan)
-1
>>> math.sign(mnan)
1

IOW a positive nan is considered negative and vice versa.  (This is
probably due to the way nans defy testing, always returning false.)

I'm also curious why math.sign(0.0) returns 1 -- this is going to cause
a lot of confusion.

This is also missing doc patches.
History
Date User Action Args
2008-01-03 00:11:01gvanrossumsetspambayes_score: 0.0367313 -> 0.0367313
recipients: + gvanrossum, mark.dickinson, Rhamphoryncus, christian.heimes
2008-01-03 00:11:00gvanrossumsetspambayes_score: 0.0367313 -> 0.0367313
messageid: <1199319060.95.0.0776451148099.issue1640@psf.upfronthosting.co.za>
2008-01-03 00:11:00gvanrossumlinkissue1640 messages
2008-01-03 00:11:00gvanrossumcreate