Author christian.heimes
Recipients albertito, christian.heimes, gvanrossum
Date 2007-12-22.10:18:48
SpamBayes Score 0.000289379
Marked as misclassified No
Message-id <1198318730.19.0.900254738092.issue1646@psf.upfronthosting.co.za>
In-reply-to
Content
I've chatted with albertito a few days ago and adviced him to post the
patch here. I'll take it.

From the first review the patch looks good. The code is written cleanly
and it uses the appropriate API. The new code is surrounded by ifdefs
and it has a patch for configure.in. I'll do the autoreconf to update
the other files locally.

The patch is missing documentation updates, Misc/NEWS update and some
unit tests. The docs should list the new constants and explain TIPC
briefly in a few sentences. You don't need to write a novell ;)
History
Date User Action Args
2007-12-22 10:18:50christian.heimessetspambayes_score: 0.000289379 -> 0.000289379
recipients: + christian.heimes, gvanrossum, albertito
2007-12-22 10:18:50christian.heimessetspambayes_score: 0.000289379 -> 0.000289379
messageid: <1198318730.19.0.900254738092.issue1646@psf.upfronthosting.co.za>
2007-12-22 10:18:49christian.heimeslinkissue1646 messages
2007-12-22 10:18:48christian.heimescreate