Author therve
Recipients christian.heimes, therve
Date 2007-12-20.18:34:19
SpamBayes Score 0.000106722
Marked as misclassified No
Message-id <1198175660.97.0.821210325881.issue1657@psf.upfronthosting.co.za>
In-reply-to
Content
Some remarks:
 * the name of the function used for PyArg_ParseTupleAndKeywords in
register, modify, unregister is set to control instead of the good name.
 * there is a leak in pyepoll_new if the parsing of arguments fails.
 * the indentation is sometimes tabs, sometimes spaces. That should be
good to unify this (to tabs I guess, since the select module used tabs
before).
 * it seems there is an unrelated change in sunau.py
 * I don't think the stdlib unittest module has skip support. You have
to find another way to skip the tests if the modules aren't present.

I've been able to port the epollreactor to your implementation and run
the whole twisted tests with it, so I don't think there are outstanding
problems. The code is fairly simple anyway.

That's it for epoll and general remarks. I'll look at kqueue asap. Thanks!
History
Date User Action Args
2007-12-20 18:34:21thervesetspambayes_score: 0.000106722 -> 0.000106722
recipients: + therve, christian.heimes
2007-12-20 18:34:21thervesetspambayes_score: 0.000106722 -> 0.000106722
messageid: <1198175660.97.0.821210325881.issue1657@psf.upfronthosting.co.za>
2007-12-20 18:34:20thervelinkissue1657 messages
2007-12-20 18:34:20thervecreate