Author therve
Recipients christian.heimes, therve
Date 2007-12-19.09:47:29
SpamBayes Score 0.00674074
Marked as misclassified No
Message-id <1198057650.81.0.28733351462.issue1657@psf.upfronthosting.co.za>
In-reply-to
Content
Cool, thanks for working on that. Just for the record, I don't really
understand the workflow: why closing the other ticket as duplicate and
not  post the patch on the old one? But whatever.

For this patch, I don't see the benefit of putting it in the select
module, instead of a separate module. Is there a specific reason?

Looking at the code, I don't have many remarks. pyepoll_new may leak if
epoll_create fails. I think that allowing threading around epoll_ctl is
useless, but I may be wrong.

Thanks again for working on it.
History
Date User Action Args
2007-12-19 09:47:31thervesetspambayes_score: 0.00674074 -> 0.00674074
recipients: + therve, christian.heimes
2007-12-19 09:47:30thervesetspambayes_score: 0.00674074 -> 0.00674074
messageid: <1198057650.81.0.28733351462.issue1657@psf.upfronthosting.co.za>
2007-12-19 09:47:30thervelinkissue1657 messages
2007-12-19 09:47:29thervecreate