Message 57895 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	JosephArmbruster
Recipients	JosephArmbruster
Date	2007-11-27.23:09:57
SpamBayes Score	0.02147498
Marked as misclassified	No
Message-id	<1196204998.62.0.0437576024742.issue1508@psf.upfronthosting.co.za>
In-reply-to

Content
I found two code blocks that look as if they can be safely removed: From _csv.c: /* begin 2.2 compatibility macros / #ifndef PyDoc_STRVAR / Define macros for inline documentation. / #define PyDoc_VAR(name) static char name[] #define PyDoc_STRVAR(name,str) PyDoc_VAR(name) = PyDoc_STR(str) #ifdef WITH_DOC_STRINGS #define PyDoc_STR(str) str #else #define PyDoc_STR(str) "" #endif #endif / ifndef PyDoc_STRVAR / From pyexpat.c: #ifndef PyDoc_STRVAR / * fdrake says: * Don't change the PyDoc_STR macro definition to (str), because * '''the parentheses cause compile failures * ("non-constant static initializer" or something like that) * on some platforms (Irix?)''' */ #define PyDoc_STR(str) str #define PyDoc_VAR(name) static char name[] #define PyDoc_STRVAR(name,str) PyDoc_VAR(name) = PyDoc_STR(str) #endif

I found two code blocks that look as if they can be safely removed:


From _csv.c:

/* begin 2.2 compatibility macros */
#ifndef PyDoc_STRVAR
/* Define macros for inline documentation. */
#define PyDoc_VAR(name) static char name[]
#define PyDoc_STRVAR(name,str) PyDoc_VAR(name) = PyDoc_STR(str)
#ifdef WITH_DOC_STRINGS
#define PyDoc_STR(str) str
#else
#define PyDoc_STR(str) ""
#endif
#endif /* ifndef PyDoc_STRVAR */


From pyexpat.c:

#ifndef PyDoc_STRVAR

/*
 * fdrake says:
 * Don't change the PyDoc_STR macro definition to (str), because
 * '''the parentheses cause compile failures
 * ("non-constant static initializer" or something like that)
 * on some platforms (Irix?)'''
 */
#define PyDoc_STR(str)         str
#define PyDoc_VAR(name)        static char name[]
#define PyDoc_STRVAR(name,str) PyDoc_VAR(name) = PyDoc_STR(str)
#endif

History
Date	User	Action	Args
2007-11-27 23:09:58	JosephArmbruster	set	spambayes_score: 0.021475 -> 0.02147498 recipients: + JosephArmbruster
2007-11-27 23:09:58	JosephArmbruster	set	spambayes_score: 0.021475 -> 0.021475 messageid: <1196204998.62.0.0437576024742.issue1508@psf.upfronthosting.co.za>
2007-11-27 23:09:58	JosephArmbruster	link	issue1508 messages
2007-11-27 23:09:57	JosephArmbruster	create