This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author draghuram
Recipients amaury.forgeotdarc, christian.heimes, draghuram, gvanrossum
Date 2007-11-06.16:12:17
SpamBayes Score 0.023420837
Marked as misclassified No
Message-id <1194365539.01.0.471765788664.issue1395@psf.upfronthosting.co.za>
In-reply-to
Content
I am attaching the patch io.diff that does the following:

- If a chunk ends in "\r", read the next chunk to check if it starts
with "\n". This is obviously a very simplified solution that can be
optimized.

- invoke _replacenl on the complete string read instead of what is being
returned in each read call.

I also incorporated the test case by Amaury and added one more.

With this patch in place, the following tests failed (on SuSE 10.1):

test_doctest test_mailbox test_nis test_old_mailbox
test_pickletools test_pty test_sys

The failures (other than known test_mailbox and test_old_mailbox) didn't
look like they are caused by this fix.
Files
File name Uploaded
io.diff draghuram, 2007-11-06.16:12:17
History
Date User Action Args
2007-11-06 16:12:19draghuramsetspambayes_score: 0.0234208 -> 0.023420837
recipients: + draghuram, gvanrossum, amaury.forgeotdarc, christian.heimes
2007-11-06 16:12:19draghuramsetspambayes_score: 0.0234208 -> 0.0234208
messageid: <1194365539.01.0.471765788664.issue1395@psf.upfronthosting.co.za>
2007-11-06 16:12:18draghuramlinkissue1395 messages
2007-11-06 16:12:17draghuramcreate