Message 56965 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	fenner
Recipients	fenner, gvanrossum
Date	2007-10-30.17:38:28
SpamBayes Score	0.020093419
Marked as misclassified	No
Message-id	<1193765908.85.0.635981154634.issue1339@psf.upfronthosting.co.za>
In-reply-to

Content
I've attached a patch against 2.4.3. The patch does the following: - Factor out the duplication of EHLO/HELO in login() and sendmail() to a new function, ehlo_or_helo_if_needed(). - Use ehlo_or_helo_if_needed() in starttls() - Check for the starttls exception in starttls() in the same way as login() checks for the auth extension.

I've attached a patch against 2.4.3.

The patch does the following:
- Factor out the duplication of EHLO/HELO in login() and sendmail() to a 
new function, ehlo_or_helo_if_needed().
- Use ehlo_or_helo_if_needed() in starttls()
- Check for the starttls exception in starttls() in the same way as 
login() checks for the auth extension.

Files
File name	Uploaded
smtplib-startls-ehlo.diff	fenner, 2007-10-30.17:38:28

History
Date	User	Action	Args
2007-10-30 17:38:28	fenner	set	spambayes_score: 0.0200934 -> 0.020093419 recipients: + fenner, gvanrossum
2007-10-30 17:38:28	fenner	set	spambayes_score: 0.0200934 -> 0.0200934 messageid: <1193765908.85.0.635981154634.issue1339@psf.upfronthosting.co.za>
2007-10-30 17:38:28	fenner	link	issue1339 messages
2007-10-30 17:38:28	fenner	create