➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author christian.heimes
Recipients brett.cannon, christian.heimes, gvanrossum
Date 2007-10-22.00:59:21
SpamBayes Score 0.019687982
Marked as misclassified No
Message-id <471BF5E7.1060400@cheimes.de>
In-reply-to <1193011852.25.0.158561440136.issue1267@psf.upfronthosting.co.za>
Content 
Guido van Rossum wrote:
> You might want to compare what I checked in to your patch; I did a few
> style cleanups.  I also moved the lseek() call into import.c, where it
> seems more appropriate.

Ah I see that you prefer to keep assignment and check against NULL/-1 on
two separate lines.

I had the lseek() in PyTokenizer_FindEncoding() because I prefer
functions that restore their environment. I find it less surprising when
it restores the position of the file descriptor.

By the way I got Windows, VS 2003 and several SDKs installed in VMWare
today. It's annoying and it takes hours. Most unit tests are passing.
http://wiki.python.org/moin/Building_Python_with_the_free_MS_C_Toolkit
History
Date User Action Args
2007-10-22 00:59:21christian.heimessetspambayes_score: 0.019688 -> 0.019687982
recipients: + christian.heimes, gvanrossum, brett.cannon
2007-10-22 00:59:21christian.heimeslinkissue1267 messages
2007-10-22 00:59:21christian.heimescreate