This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author christian.heimes
Recipients brett.cannon, christian.heimes, gvanrossum
Date 2007-10-21.04:40:44
SpamBayes Score 0.04836592
Marked as misclassified No
Message-id <1192941646.96.0.901982833563.issue1267@psf.upfronthosting.co.za>
In-reply-to
Content
> I think find_module() should return a file descriptor (fd), not a
> FILE*, but most of the rest of the code should call fdopen() on that
> fd. Only call_find_module() should use the fd to turn it into a Python
> file object. Then the amount of change should be pretty minimal.

I'd have to touch most functions in import.c and related files to change
find_module() to use a file descriptor. It's a PITA and I don't think
it's worse the effort for now.

The new patch adds PyFile_FromFd and removes the other PyFile_FromFile*
functions. It also changes some methods to use a file descriptor and
some documentation. Two minor changes aren't related to the bug but they
nagged me.
Files
File name Uploaded
py3k_filefromfd.patch christian.heimes, 2007-10-21.04:40:45
History
Date User Action Args
2007-10-21 04:40:47christian.heimessetspambayes_score: 0.0483659 -> 0.04836592
recipients: + christian.heimes, gvanrossum, brett.cannon
2007-10-21 04:40:46christian.heimessetspambayes_score: 0.0483659 -> 0.0483659
messageid: <1192941646.96.0.901982833563.issue1267@psf.upfronthosting.co.za>
2007-10-21 04:40:46christian.heimeslinkissue1267 messages
2007-10-21 04:40:45christian.heimescreate